Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MS Edge and Firefox issues #342, #388 #393

Merged
merged 5 commits into from
May 12, 2016
Merged

Fix MS Edge and Firefox issues #342, #388 #393

merged 5 commits into from
May 12, 2016

Conversation

davidgabrichidze
Copy link
Contributor

@davidgabrichidze davidgabrichidze commented May 5, 2016

Fix md-input maxLength problem for MS Edge #388
Fix floating placeholder in Firefox, without affecting autofill behavior in Chrome/Safari #342

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label May 5, 2016
@davidgabrichidze davidgabrichidze changed the title Fix MS Edge and Firefox issues #342, #392 Fix MS Edge and Firefox issues #342, #388 May 5, 2016
@davidgabrichidze
Copy link
Contributor Author

I've signed it 2 days ago, where is my cla:yes :))))

@devversion
Copy link
Member

@davidgabrichidze This is caused by your multiple commits. Some commits are not committed properly with your GitHub Account Email.

I suggest, squashing all commits into one, then the CLA check will pass properly.

@davidgabrichidze
Copy link
Contributor Author

@devversion thanks for advise. So, I should close this PR and request another one, with joined commits?

@devversion
Copy link
Member

@davidgabrichidze That shouldn't be necessary. You can just squash the commits on this PR and force push the changes.

Here is a useful Git Alias for Squashing

  squash = "!f(){ git reset --soft HEAD~${1} && git commit --edit -m\"$(git log --format=%B --reverse HEAD..HEAD@{1})\"; };f"

And here is another link for squashing: http://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

Fix floating placeholder in Firefox, without affecting autofill behavior in Chrome/Safari

Override and remove firefox box-shadow on required fields
@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels May 7, 2016
@davidgabrichidze
Copy link
Contributor Author

@devversion Thanks, it worked 👍

* Removes firefox box-shadow on required fields...
*/
:-moz-ui-invalid {
box-shadow: none;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-2 indent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels May 9, 2016
@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels May 9, 2016
@jelbourn
Copy link
Member

LGTM

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants