-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: changes necessary for adding support for offline compiler #835
Conversation
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
As discussed, we want to add back the |
I'm going to squash this change for the CLA bot. /me pets bot |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
LGTM |
5129fb0
to
dabd12e
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The
module.id
changes aren't going to work with dynamic platform browser in development mode (demo app). Unfortunately, they're necessary to remove to get the metadata extraction working (since metadata cannot execute code).They will go away with the webpack change to the CLI anyway.