Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changes necessary for adding support for offline compiler #835

Merged
merged 1 commit into from
Jul 13, 2016

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Jul 8, 2016

The module.id changes aren't going to work with dynamic platform browser in development mode (demo app). Unfortunately, they're necessary to remove to get the metadata extraction working (since metadata cannot execute code).

They will go away with the webpack change to the CLI anyway.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jul 8, 2016
@jelbourn
Copy link
Member

As discussed, we want to add back the moduleId until the CLI doesn't need it any more.

@hansl
Copy link
Contributor Author

hansl commented Jul 12, 2016

I'm going to squash this change for the CLA bot. /me pets bot

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jul 12, 2016
@jelbourn
Copy link
Member

LGTM

@hansl hansl force-pushed the offline-compiler branch 2 times, most recently from 5129fb0 to dabd12e Compare July 12, 2016 23:32
@jelbourn jelbourn merged commit 4bb7790 into master Jul 13, 2016
@jelbourn jelbourn deleted the offline-compiler branch October 20, 2016 23:02
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants