Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(md-input): MdInput with type date cannot handle placeholders #845

Closed
drager opened this issue Jul 12, 2016 · 3 comments · Fixed by #846
Closed

bug(md-input): MdInput with type date cannot handle placeholders #845

drager opened this issue Jul 12, 2016 · 3 comments · Fixed by #846
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone

Comments

@drager
Copy link
Contributor

drager commented Jul 12, 2016

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Placeholders should always be small for date inputs since it defaults to: mm/dd/yyyy.

What is the current behavior?

Placeholder is large for the default value for date inputs.

What are the steps to reproduce?

http://plnkr.co/edit/MURSTrNjlRj3AGzZkEfO?p=preview

Which versions of Angular, Material, OS, browsers are affected?

  • Angular version: 2.0.0-rc.4
  • Material version: 2.0.0-alpha.6
  • Browser: Chrome Version 51.0.2704.106 (64-bit)
  • Language: TypeScript 2.0.0-dev
  • Built with: Webpack
@msegers
Copy link

msegers commented Jul 12, 2016

The date input will get a picker. For now I'd suggest styling the label as if it was always filled in (that's what I do).

drager added a commit to drager/material2 that referenced this issue Jul 12, 2016
@drager
Copy link
Contributor Author

drager commented Jul 12, 2016

@msegers: I see, styling it though seems like an ugly hack to be honest... I added a pull that fixes the bug described above.

drager added a commit to drager/material2 that referenced this issue Jul 14, 2016
@jelbourn jelbourn added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jul 14, 2016
@jelbourn jelbourn added this to the alpha.7 milestone Jul 14, 2016
drager added a commit to drager/material2 that referenced this issue Jul 27, 2016
@hansl hansl closed this as completed in #846 Sep 6, 2016
hansl pushed a commit that referenced this issue Sep 6, 2016
…eld. (#846)

* fix(MdInput): Input should not be treated as empty if it is a date field. Fixes #845

* fix(MdInput): Input should not be treated as empty if it is a date field. Fixes #845

* fix(md-input): Check for type in empty getter instead

* test(MdInput): Add tests for empty check

* test(MdInput): Update empty check tests to match the other tests new syntax

* test(MdInput): Fix linting issue

* fix(MdInput): Input should not be treated as empty if it is a date field. Fixes #845

* fix(md-input): Check for type in empty getter instead

* fix(md-input): Check for type in empty getter instead

* test(MdInput): Add tests for empty check

* test(MdInput): Update empty check tests to match the other tests new syntax

* test(MdInput): Skip empty check tests for IE11

* test(MdInput): Resolve linting issues

* test(MdInput): Update empty() check tests to match new test syntax
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants