feat(menu): add custom position support to menu #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -22,10 +24,21 @@ import { | |||
| }) | |||
| export class MdMenu { | |||
| private _showClickCatcher: boolean = false; | |||
| private _classList: Object; | |||
| positionX: 'before' | 'after' = 'after'; | |||
| positionY: 'above' | 'below' = 'below'; | |||
There was a problem hiding this comment.
Create a type for these, i.e.,
export type MenuPositionX: 'before' | 'after';There was a problem hiding this comment.
Good call! Way better.
kara
force-pushed
the
position
branch
4 times, most recently
from
6ca221e
to
0829631
Compare
| page = new MenuPage(); | ||
| }); | ||
|
|
||
| it('should open menu when the trigger is clicked', function () { |
| @@ -22,10 +26,34 @@ import { | |||
| }) | |||
| export class MdMenu { | |||
| private _showClickCatcher: boolean = false; | |||
| private _classList: Object; | |||
There was a problem hiding this comment.
Object isn't super clear; add a comment explaining that this is the input into ngClass with an example?
|
LGTM aside from existing comments; did you figure out the scrollbars on SauceLabs thing? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r: @jelbourn
This PR adds custom position support to menu. The default menu opens "after" and "below" the trigger. If you want to change that, you can modify the "x-position" and "y-position" attributes (see design doc here).
x-position: 'before' | 'after'
y-position: 'above' | 'below'
Examples:
FYI, this PR needs to wait until my other menu PR goes in, so check out the last commit.