This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
fix(driverProviders): Handle promise rejection when starting selenium #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
cnishina
reviewed
Jan 19, 2017
| @@ -113,6 +111,10 @@ export class Local extends DriverProvider { | |||
| if (serverConf.port === undefined) { | |||
| serverConf.port = this.config_.seleniumPort; | |||
| } | |||
| if (!Array.isArray(serverConf.jvmArgs)) { | |||
| logger.warn('jvmArgs should be an array!'); | |||
There was a problem hiding this comment.
We should throw a ConfigError here OR change the lib/config.ts to say that jvmArgs type is string|string[].
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
…angular#3989) Fixes angular#3986. Also error if jvmArgs isn't an array.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3986. Also warn if jvmArgs isn't an array.