Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

fix(element): removed WebElement getSize and getLocation for getRect #5227

Merged
merged 2 commits into from
Jun 6, 2019
Merged

fix(element): removed WebElement getSize and getLocation for getRect #5227

merged 2 commits into from
Jun 6, 2019

Conversation

kolodiy
Copy link
Contributor

@kolodiy kolodiy commented Apr 30, 2019

As per the selenium4 changelog removed WebElement getSize and getLocation for getRect.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kolodiy
Copy link
Contributor Author

kolodiy commented Apr 30, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@kolodiy
Copy link
Contributor Author

kolodiy commented May 8, 2019

@cnishina, @juliemr can you please review?

'getLocation', 'isEnabled', 'isSelected', 'submit', 'clear', 'isDisplayed', 'getId',
'takeScreenshot'
'click', 'sendKeys', 'getTagName', 'getCssValue', 'getAttribute', 'getText', 'getRect',
'isEnabled', 'isSelected', 'submit', 'clear', 'isDisplayed', 'getId', 'takeScreenshot'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isDisplayed also removed. Or here we use own script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CrispusDH , I still see isDisplayed in https://github.com/SeleniumHQ/selenium/blob/selenium-4.0.0-alpha-1/javascript/node/selenium-webdriver/lib/webdriver.js. Also it is listed in the dependency spec, please see: spec/dependencyTest/seleniumWebdriver_spec.js

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is right. I did not clean up this list.

'getLocation', 'isEnabled', 'isSelected', 'submit', 'clear', 'isDisplayed', 'getId',
'takeScreenshot'
'click', 'sendKeys', 'getTagName', 'getCssValue', 'getAttribute', 'getText', 'getRect',
'isEnabled', 'isSelected', 'submit', 'clear', 'isDisplayed', 'getId', 'takeScreenshot'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is right. I did not clean up this list.

@kolodiy
Copy link
Contributor Author

kolodiy commented Jun 6, 2019

@cnishina @juliemr can you please merge this PR? We would like to migrate our tests to Protractor6, but this issue currently blocks us.

@cnishina cnishina merged commit cc501f7 into angular:master Jun 6, 2019
@kolodiy
Copy link
Contributor Author

kolodiy commented Jun 7, 2019

@cnishina thanks for the quick reply. We also need a new package version with these changes to be released.
I saw that the next planned release is 6.0.1-beta.1. Are there any planned dates for this release?
What about releasing it with these changes for now? I can help with changelog and PR with version bump.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants