Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Bug: Support properties that don't take a function #17

Closed
tbosch opened this issue Apr 24, 2014 · 1 comment
Closed

Bug: Support properties that don't take a function #17

tbosch opened this issue Apr 24, 2014 · 1 comment
Assignees

Comments

@tbosch
Copy link

tbosch commented Apr 24, 2014

Setting xhr.responseType = 'document' is a noop right now (given xhr = new XMLHttpRequest()).

In https://github.com/angular/zone.js/blob/master/zone.js#L347 the else case is missing, i.e.

           if (typeof fn === 'function') {
              this._o[prop] = zone.bind(fn);
            } else {
              this._o[prop] = fn;
            }
@btford
Copy link
Contributor

btford commented Apr 24, 2014

👍

@btford btford closed this as completed in fb46688 Apr 24, 2014
@btford btford added the bug label Apr 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants