This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Patch EventTarget methods on Window in browsers without EventTarget (fixes #367) #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxhub
force-pushed
the
patch-window-in-safari
branch
from
2ecb254
to
f81e7b0
Compare
alxhub
changed the title
alxhub
force-pushed
the
patch-window-in-safari
branch
from
f81e7b0
to
1ffb990
Compare
In browsers without EventTarget, window.addEventListener() is not patched. Fixes angular#367.
alxhub
force-pushed
the
patch-window-in-safari
branch
from
1ffb990
to
243babf
Compare
|
Change LGTM, can you get the tests green? |
|
I've been trying - they seemed to be failing due to an issue starting one of the browsers, unrelated to the change. |
|
Yes, the red is from master, rerunning. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.