This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
feat(node): patch outgoing http requests to capture the zone #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return new ClientRequest(options); | ||
| } else { | ||
| let zone = Zone.current; | ||
| return new ClientRequest(options, zone.wrap(callback, '_http_client.ClientRequest.constructor')); |
There was a problem hiding this comment.
why _http_client.ClientRequest.constructor? Why not just http.ClientRequest?
alxhub
force-pushed
the
node-patch-http
branch
2 times, most recently
from
8263b30
to
ffaa33e
Compare
alxhub
force-pushed
the
node-patch-http
branch
from
ffaa33e
to
b67ae56
Compare
|
@mhevery, this should be good to go. |
alxhub
force-pushed
the
node-patch-http
branch
from
b67ae56
to
480eb72
Compare
55 tasks
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.