Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GitHub Oauth Login and Registration #107

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Added GitHub Oauth Login and Registration #107

wants to merge 3 commits into from

Conversation

codesankalp
Copy link
Member

@codesankalp codesankalp commented Mar 4, 2021 •
edited
Loading

Description

Added the code to make POST request on backend to send code and recieve access_token.

Fixes #106

Type of Change:

  • Code
  • User Interface
  • Documentation
  • Tests

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

github

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented on my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests for my change.

Code/Quality Assurance Only

  • My changes generate no new warnings

@codesankalp codesankalp added the Status: Needs Review PR needs an additional review or a maintainer's review. label Mar 4, 2021
@codesankalp
Copy link
Member Author

Backend Pull request to test this feature: anitab-org/anitab-forms-backend#109

If facing a problem in running the development server of the frontend. Try this:

rm -rf node_modules/
npm install --force
npm start

nlok5923
nlok5923 reviewed Mar 5, 2021
View reviewed changes
src/components/Login.js Outdated Show resolved Hide resolved
nlok5923
nlok5923 reviewed Mar 5, 2021
View reviewed changes
Copy link
Contributor

@nlok5923 nlok5923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review the suggestion.

@codesankalp
Copy link
Member Author

@isabelcosta Can you review this PR?

jeeva2812
jeeva2812 suggested changes Mar 8, 2021
View reviewed changes
src/components/GitHubAuth.js Outdated Show resolved Hide resolved
src/components/GitHubAuth.js Outdated Show resolved Hide resolved
jeeva2812
jeeva2812 previously approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@jeeva2812 jeeva2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@isabelcosta
Copy link
Member

@codesankalp I just merged the prettier styling PR 🙈 could you please fix the merge conflicts?

@codesankalp
Added GitHub Oauth Login and Registration
dfe38a8 
Added the code to make POST request on backend to send code and recieve access_token.

Fixes anitab-org#106
@codesankalp
Added tests and removed with router
46387d7
@codesankalp
Copy link
Member Author

@isabelcosta Removed the merge conflict but there is a problem with QA-Checks.

@codesankalp
Copy link
Member Author

@isabelcosta Should I add the workflow for tests here?

@codesankalp
Copy link
Member Author

I am fixing the conflicts and Will update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlok5923 nlok5923 nlok5923 left review comments

@jeeva2812 jeeva2812 jeeva2812 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GitHub Oauth Login and Registration
4 participants
@codesankalp @isabelcosta @jeeva2812 @nlok5923