Updated Zulip.js #180

msaini28r · 2021-10-15T05:23:04Z

Description

Fixes #72

Type of Change:

Code
Quality Assurance
User Interface
Outreach
Documentation

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update (software upgrade on readme file)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
Any dependent changes have been merged

I think the issue is solved. #72

msaini28r · 2021-10-15T05:23:46Z

The issue is solved. #72

codesankalp

See my comments @msaini0r 👇

codesankalp · 2021-10-15T06:17:21Z

src/components/Zulip.js

@@ -59,10 +59,6 @@ class Zulip extends Component {
                    <b>Streams: </b>
                    <br />
                    <ul>
-                      <li>
-                        <b>#newcomers: </b>
-                        {zulipstat[0] ? zulipstat[0].newcomers_messages : 0}


Why are you removing this?
You need to change the condition so that it can render without any errors.

{zulipstat && zulipstat[0] && zulipstat[0].newcomers_message ? zulipstat[0].newcomers_message : 0}

Same change for other lines also.

@codesankalp can you please check if I made the right changes?

codesankalp · 2021-10-15T07:11:15Z

src/components/Zulip.js

@@ -1,121 +0,0 @@
-import React, { Component } from 'react';
-import { connect } from 'react-redux';


@msaini0r You have removed the whole code from this file. Please revert it.

@can you give me instructions how to revert it. @codesankalp

@codesankalp should i delete that branch?

This reverts commit 9593b3f.

codesankalp · 2021-10-16T09:29:52Z

src/components/Zulip.js

@@ -61,23 +61,23 @@ class Zulip extends Component {
                    <ul>
                      <li>
                        <b>#newcomers: </b>
-                        {zulipstat[0] ? zulipstat[0].newcomers_messages : 0}
+                        {zulipstat && zulipstat[0] && zulipstat[0].newcomers_message ? zulipstat[0].newcomers_message : 0}


This line looks repeated for zulipstat && zulipstat[0]. Can you please remove this zulipstat && zulipstat[0] from each line and add zulipstat && zulipstat[0] in parent tag (ul)?

Suggested change

{zulipstat && zulipstat[0] && zulipstat[0].newcomers_message ? zulipstat[0].newcomers_message : 0}

{zulipstat[0].newcomers_message ? zulipstat[0].newcomers_message : 0}

@codesankalp check now changes done.

codesankalp · 2021-10-16T09:57:52Z

src/components/Zulip.js

@@ -58,26 +58,26 @@ class Zulip extends Component {
                  <>
                    <b>Streams: </b>
                    <br />
-                    <ul>
+                    <zulipstat && zulipstat[0]>


Suggested change

<zulipstat && zulipstat[0]>

{zulipstat && zulipstat[0] ? <ul>below code<ul> : null}

msaini28r

@codesankalp see!!

isabelcosta · 2021-10-17T12:52:11Z

@msaini0r please edit the pull request description with a description of the changes and how you tested this? This is a good practice for future PRs, whether it's in our community or other projects, and good for documentation purposes 🤗

isabelcosta

@msaini0r could you please check why the PR check is failing? This seems to be related to your PR. Once you fix the failing check I can approve this PR and merge it.

isabelcosta · 2021-10-17T20:36:03Z

removed Ready to Merge label as the PR checks are failing cc @Aaishpra

msaini28r · 2021-10-18T07:07:05Z

@isabelcosta I am not able to find the issue. I would like to worrk on some other issues

Aaishpra · 2021-10-18T07:15:12Z

@isabelcosta I am not able to find the issue. I would like to worrk on some other issues

Hi @msaini0r only linters and formatters check is failing if you can fix them it would be great
Try running npm run lint to fix them
Pasting the error log here so you can have a look.

 
Linters and Formatters
failed 18 hours ago in 58s
Search logs
3s
1s
3s
47s
4s
Run npm run lint

> [email protected] lint /home/runner/work/anitab-forms-web/anitab-forms-web
> eslint .


/home/runner/work/anitab-forms-web/anitab-forms-web/src/components/Zulip.js
Error:   61:50  error  Insert `(⏎······················`                                                                                                                                                                                                                                             prettier/prettier
Error:   62:23  error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   63:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   64:25  error  Replace `{zulipstat[0].newcomers_message·?·zulipstat[0].newcomers_message` with `··{zulipstat[0].newcomers_message⏎····························?·zulipstat[0].newcomers_message⏎···························`                                                                  prettier/prettier
Error:   65:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   66:23  error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   67:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   68:1   error  Replace `························{zulipstat[0].celebrate_message·?·zulipstat[0].celebrate_message` with `··························{zulipstat[0].celebrate_message⏎····························?·zulipstat[0].celebrate_message⏎···························`                  prettier/prettier
Error:   69:1   error  Replace `······················` with `························`                                                                                                                                                                                                              prettier/prettier
Error:   70:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   71:25  error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   72:1   error  Replace `························{zulipstat[0].opportunities_message·?·zulipstat[0].opportunities_message` with `··························{zulipstat[0].opportunities_message⏎····························?·zulipstat[0].opportunities_message⏎···························`  prettier/prettier
Error:   73:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   74:23  error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   75:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   76:25  error  Replace `{zulipstat[0].questions_message·?·zulipstat[0].questions_message` with `··{zulipstat[0].questions_message⏎····························?·zulipstat[0].questions_message⏎···························`                                                                  prettier/prettier
Error:   77:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   78:23  error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   79:1   error  Replace `························` with `··························`                                                                                                                                                                                                          prettier/prettier
Error:   80:1   error  Replace `·······················{zulipstat[0].general_message·?·zulipstat[0].general_message` with `··························{zulipstat[0].general_message⏎····························?·zulipstat[0].general_message⏎···························`                           prettier/prettier
Error:   81:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   82:1   error  Replace `····················</ul>` with `······················</ul>⏎····················)`                                                                                                                                                                                  prettier/prettier`

msaini28r · 2021-10-18T07:45:49Z

@Aaishpra already tried npm run lint but it is showing me an error.

Updated Zulip.js

297e594

I think the issue is solved. #72

codesankalp suggested changes Oct 15, 2021

View reviewed changes

msaini28r added 2 commits October 15, 2021 12:18

Update Zulip.js

34d8cb3

Delete Zulip.js

9593b3f

codesankalp suggested changes Oct 15, 2021

View reviewed changes

codesankalp added the Status: Changes Requested Changes are required to be done by the PR author. label Oct 15, 2021

Revert "Delete Zulip.js"

5b176e1

This reverts commit 9593b3f.

codesankalp reviewed Oct 16, 2021

View reviewed changes

Update Zulip.js

caf53a6

codesankalp reviewed Oct 16, 2021

View reviewed changes

Update Zulip.js

f9fa49e

msaini28r commented Oct 16, 2021

View reviewed changes

codesankalp approved these changes Oct 16, 2021

View reviewed changes

codesankalp added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Oct 16, 2021

Aaishpra approved these changes Oct 16, 2021

View reviewed changes

isabelcosta requested changes Oct 17, 2021

View reviewed changes

isabelcosta removed the Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. label Oct 17, 2021

msaini28r closed this Oct 19, 2021

msaini28r deleted the patch-1 branch October 19, 2021 16:48

msaini28r restored the patch-1 branch October 19, 2021 16:48

AaryaDarisi mentioned this pull request Feb 23, 2024

Bug: Streamwise messages not showing on zulip stat card to admin #72

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated Zulip.js #180

Updated Zulip.js #180

msaini28r commented Oct 15, 2021 •

edited by isabelcosta

Loading

msaini28r commented Oct 15, 2021

codesankalp left a comment

codesankalp Oct 15, 2021

msaini28r Oct 15, 2021

codesankalp Oct 15, 2021

msaini28r Oct 15, 2021

msaini28r Oct 15, 2021

codesankalp Oct 16, 2021

msaini28r Oct 16, 2021

codesankalp Oct 16, 2021

msaini28r left a comment

isabelcosta commented Oct 17, 2021

isabelcosta left a comment

isabelcosta commented Oct 17, 2021

msaini28r commented Oct 18, 2021

Aaishpra commented Oct 18, 2021

msaini28r commented Oct 18, 2021

		@@ -1,121 +0,0 @@
		import React, { Component } from 'react';
		import { connect } from 'react-redux';

	{zulipstat && zulipstat[0] && zulipstat[0].newcomers_message ? zulipstat[0].newcomers_message : 0}
	{zulipstat[0].newcomers_message ? zulipstat[0].newcomers_message : 0}

	<zulipstat && zulipstat[0]>
	{zulipstat && zulipstat[0] ? <ul>below code<ul> : null}

Updated Zulip.js #180

Updated Zulip.js #180

Conversation

msaini28r commented Oct 15, 2021 • edited by isabelcosta Loading

Description

Type of Change:

How Has This Been Tested?

Checklist:

msaini28r commented Oct 15, 2021

codesankalp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msaini28r left a comment

Choose a reason for hiding this comment

isabelcosta commented Oct 17, 2021

isabelcosta left a comment

Choose a reason for hiding this comment

isabelcosta commented Oct 17, 2021

msaini28r commented Oct 18, 2021

Aaishpra commented Oct 18, 2021

msaini28r commented Oct 18, 2021

msaini28r commented Oct 15, 2021 •

edited by isabelcosta

Loading