Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor code to use functional components. #76

Open
pranay-simejia opened this issue Feb 12, 2021 · 9 comments
Open

Refractor code to use functional components. #76

pranay-simejia opened this issue Feb 12, 2021 · 9 comments
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. Type: Enhancement New feature or request.

Comments

@pranay-simejia
Copy link

Is your feature request related to a problem? Please describe.

As mentioned in React Docs after react-hook support, one should prefer using functional components.

Describe the solution you'd like

Convert all class based components to functional components.

Describe alternatives you've considered

for example, componentdDidMount can be replaced by useEffect hook.

@pranay-simejia
Copy link
Author

Can I work on this issue?

@Rahulm2310
Copy link
Contributor

@pranay-simejia I don't think this should have a priority currently. But, yeah, please wait for a maintainer to confirm/approve this issue before starting to work on the fix. Thanks 🙂

Cc: @isabelcosta

@isabelcosta
Copy link
Member

@pranay-simejia , @Rahulm2310 is correct. Right now we are trying to get this project to the MVP (minimum viable product) status. You can find more information on documentation on this zulip message.
However, how much effort do you think this requires? Also, could you check on Zulip if more community members feel like this is a priority?

@isabelcosta isabelcosta added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request. labels Feb 13, 2021
@pranay-simejia
Copy link
Author

pranay-simejia commented Feb 14, 2021

Switching to functional components can be done within 2 days. Single person's job.
@isabelcosta

@jalajcodes
Copy link
Member

Switching to functional components can be done within 2 days. Single person's job.
@isabelcosta

Yeah I think there's also a vscode extension to do this too😅 I can't remember its name 🤔

@ayan-biswas0412
Copy link
Contributor

Switching to functional components can be done within 2 days. Single person's job.
@isabelcosta

Yeah I think there's also a vscode extension to do this too😅 I can't remember its name 🤔

i think @jalajcodes you are talking abou this https://marketplace.visualstudio.com/items?itemName=wix.glean

@shruti1421
Copy link
Contributor

I have also created this same issue earlier. Here is the issue number #69.
If you give confirmation for this issue, I would to like to work on this.

@Aaishpra
Copy link
Member

@shruti1421 @pranay-simejia since we are currently focusing more on completion of MVP(minimum viable product) i don't think this issue is of much use at this moment (considering it will require change in a lot of files and can cause a blocker to other features as well as current PRs) this issue can be put to hold until we have enough features and workforce for managing the project

@ayan-biswas0412
Copy link
Contributor

ayan-biswas0412 commented Feb 14, 2021

@shruti1421 @pranay-simejia since we are currently focusing more on completion of MVP(minimum viable product) i don't think this issue is of much use at this moment (considering it will require change in a lot of files and can cause a blocker to other features as well as current PRs) this issue can be put to hold until we have enough features and workforce for managing the project

ok

@Aaishpra Aaishpra added the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. Type: Enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

7 participants