Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Short the text in events cards and add a new page to display full details #237

Open
Rahulm2310 opened this issue Feb 19, 2021 · 9 comments · May be fixed by #244
Open

Feat: Short the text in events cards and add a new page to display full details #237

Rahulm2310 opened this issue Feb 19, 2021 · 9 comments · May be fixed by #244
Assignees

Comments

@Rahulm2310
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, full text is displayed in the event cards.
anitab-events-card-issue

Describe the solution you'd like

We should shorten the text in the events cards, add a Read more button in the card and add a new event details page to display full details of event.
Something like this can be achieved.
image

@Rahulm2310
Copy link
Contributor Author

@annabauza @nandini45 What do you guys think?

@nandini45
Copy link
Member

agreed @Rahulm2310 and also we may need to shorten the content its way too long

@Rahulm2310
Copy link
Contributor Author

@annabauza @nandini45 If approved, I would like take this up.

@nandini45
Copy link
Member

@Rahulm2310 i think i misread the solution firstly.
please do as needed
thanks for the work

@Rahulm2310
Copy link
Contributor Author

Rahulm2310 commented Feb 26, 2021

@nandini45 I have tried to tackle this. Here are my changes. I have shortened the text in the event card and added a modal popup to display the complete details. Please share your views.
anitab-events-fix

@nandini45
Copy link
Member

nandini45 commented Feb 27, 2021

great work @Rahulm2310
just one question have you changed the corner edges
if yes i think not all the corner have being changed, the size of the corner edges should be same for all edges
image

@Rahulm2310
Copy link
Contributor Author

@nandini45 I have not changed the edges. It is also there in the live project as well.
image
This is a screenshot from the live project.

@nandini45
Copy link
Member

ok @Rahulm2310
you want to create a issue of it
if yes go ahead. it can be quite an easy 1st timer issue if you want
and for your work
its perfect please create a PR

@Rahulm2310
Copy link
Contributor Author

Sure. Thanks @nandini45 .

@Rahulm2310 Rahulm2310 linked a pull request Feb 27, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants