Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research : protocol buffers #228

Open
epicadk opened this issue Mar 26, 2021 · 4 comments
Open

Research : protocol buffers #228

epicadk opened this issue Mar 26, 2021 · 4 comments
Labels
Category: Outreach/Research Changes or improvements related to external research of the app. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner.

Comments

@epicadk
Copy link
Member

epicadk commented Mar 26, 2021

Is your feature request related to a problem? Please describe.

Currently the app uses sends and receives JSON data. While this is fine when we send/receive data to/from the user (as JSON is human readable) the calls to the mentorship backend do not need to be human readable and can be in the binary form.

Describe the solution you'd like

Research on the possibility of using protocol buffers and write a doc. In your doc include the advantages / disadvantages of protobufs over JSON and vice versa in context with BIT (You do not need to propose an implementation).

Describe alternatives you've considered

You could also include a comparison with any other standard that you think would be better (eg. flat buffers) ( This would be optional and not required).

@epicadk epicadk added Category: Outreach/Research Changes or improvements related to external research of the app. Open Source Hack Status: Available Issue was approved and available to claim or abandoned for over 3 days. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. and removed Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Mar 26, 2021
@epicadk
Copy link
Member Author

epicadk commented Mar 26, 2021

Putting status on hold. Needs discussion with @mtreacy002.

@mtreacy002
Copy link
Member

mtreacy002 commented Mar 26, 2021

@epicadk , is this because for better security? I agree, it would be an interesting topic. Although probably would only be implemented once we already have a stable version in the production (so we still have a long way to go). Especially since there aren't many resources out there to support us in developing this way (protobuf) compared to in json. I reckon we should put this in icebox and revisit it (the discussion) when we are ready. I feel discussing it too early will be redundant since by the time we ready to implement and revisit this topic in the future, there'll be an improved methods and resources available to us. I like to have OSH to focus on the closer issues, such as remote servers alternative, users' micro service, and alternative to keeping user data in cookies. Let me know what you think.

@epicadk
Copy link
Member Author

epicadk commented Mar 27, 2021

It's not for security it is just an enhancement. It would reduce the size of the requests to the mentorship backend making these calls faster and wouldn't require as much code for validating the schema. Hmm yes I agree I think we can revisit this later.

@matsy
Copy link

matsy commented May 17, 2023

@mtreacy002 Is someone working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Outreach/Research Changes or improvements related to external research of the app. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner.
Projects
None yet
Development

No branches or pull requests

3 participants