Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: added typehints to Organization module #246 #296

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor: added typehints to Organization module #246 #296

wants to merge 1 commit into from

Conversation

snifhex
Copy link

@snifhex snifhex commented Aug 10, 2021

Description

Fixes #246

Type of Change:

  • Code

Code/Quality Assurance Only

  • New feature (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@welcome
Copy link

welcome bot commented Aug 10, 2021

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request.✨ AnitaB.org is an inclusive community, committed to creating a safe and positive environment.🌸Please adhere to our Code of Conduct and Contribution Guidelines.🙌.We will get back to you as soon as we can.😄

Feel free to join us on AnitaB.org Open Source Zulip Community.💖 We have different streams for each active repository for discussions.✨ Hope you have a great time there!😄

@vj-codes vj-codes added the Status: Needs Review PR needs an additional review or a maintainer's review. label Sep 20, 2021
@vj-codes
Copy link
Member

@isabelcosta @mtreacy002 any idea why the github action checks are not triggered here? 👀

@isabelcosta
Copy link
Member

No idea @vj-codes 😱

@isabelcosta isabelcosta closed this Oct 8, 2021
@isabelcosta isabelcosta reopened this Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreacy002 mtreacy002 Awaiting requested review from mtreacy002 mtreacy002 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement: Add typehints to Organization module
3 participants
@snifhex @vj-codes @isabelcosta