feat: Add form and question models #25
Conversation
osp/admin.py
Outdated
| @@ -3,5 +3,13 @@ | |||
| from osp.models import * | |||
There was a problem hiding this comment.
No! Please don't. Never do this
osp/models/__init__.py
Outdated
| from osp.models.question import Question | ||
| from osp.models.abstract_timestamp import AbstractTimestamp | ||
| from osp.models.field import * |
osp/models/abstract_timestamp.py
Outdated
| ) | ||
|
|
||
| class Meta: | ||
|
|
There was a problem hiding this comment.
extra line, please remove
osp/models/abstract_timestamp.py
Outdated
| Abstract model for Created Time and Updated Time fields | ||
| """ | ||
|
|
||
| created_on = models.DateTimeField( |
There was a problem hiding this comment.
single param, same line should suffice
osp/models/question.py
Outdated
|
|
||
| from osp.models.abstract_timestamp import AbstractTimestamp | ||
|
|
||
| SA = 'char' |
There was a problem hiding this comment.
Create a separate directory for utilities, This new dir should contain all the abstract or generic models, functions, choices, views and manager.
osp/models/form.py
Outdated
|
|
||
| def __str__(self): | ||
|
|
||
| return f'{self.name}' |
There was a problem hiding this comment.
F formatting for a single param doesn't makes sense
There was a problem hiding this comment.
Without f the display is {self.name}. I feel it is needed!
osp/models/form.py
Outdated
| description = models.TextField( | ||
| blank=True | ||
| ) | ||
| created_on = models.DateTimeField( |
There was a problem hiding this comment.
You are already inheriting AbstractTimestamp. no need to add these 2 fields again
There was a problem hiding this comment.
Please make the changes suggested by @Monal5031. I don't see any other changes.
Description
Fixes #17
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
The models are created and migrations run:
Checklist:
Code/Quality Assurance Only