Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature for viewing, creating and editing answers #31

Merged
merged 3 commits into from
Aug 28, 2020
Merged

Add feature for viewing, creating and editing answers #31

merged 3 commits into from
Aug 28, 2020

Conversation

bismitaguha
Copy link
Contributor

@bismitaguha bismitaguha commented Jul 23, 2020 •
edited
Loading

Description

Fixes #11, fixes #12 , fixes #13

Type of Change:

  • Code
  • Quality Assurance
  • Documentation

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Newman tests

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

Monal5031
Monal5031 suggested changes Jul 26, 2020
View reviewed changes
osp/models/form_feedback.py Show resolved Hide resolved
osp/views/answer.py Show resolved Hide resolved
osp/views/answer.py Show resolved Hide resolved
Monal5031
Monal5031 reviewed Jul 26, 2020
View reviewed changes
osp/views/answer.py Outdated Show resolved Hide resolved
Monal5031
Monal5031 suggested changes Jul 27, 2020
View reviewed changes
osp/models/form_feedback.py Show resolved Hide resolved
osp/serializers/form_feedback.py Outdated Show resolved Hide resolved
osp/serializers/answer.py Show resolved Hide resolved
osp/serializers/form_feedback.py Show resolved Hide resolved
osp/serializers/form_feedback.py Show resolved Hide resolved
osp/views/answer.py Outdated Show resolved Hide resolved
osp/views/answer.py Outdated Show resolved Hide resolved
osp/views/answer.py Outdated Show resolved Hide resolved
osp/views/form.py Outdated Show resolved Hide resolved
Monal5031
Monal5031 suggested changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@Monal5031 Monal5031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the form feedback API in this PR directly and please rebase your PR

osp/views/answer.py Show resolved Hide resolved
Monal5031
Monal5031 suggested changes Aug 2, 2020
View reviewed changes
Copy link
Contributor

@Monal5031 Monal5031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Read and Write serializer for Answer and FormFeedback
  2. Move from AnswerView to FormFeedbackView
  3. Keep serializer_class to Read as default and use Write ones as and when needed

osp/models/form_feedback.py Show resolved Hide resolved
osp/models/form_feedback.py Show resolved Hide resolved
osp/models/value.py Show resolved Hide resolved
osp/serializers/answer_create.py Outdated Show resolved Hide resolved
osp/serializers/answer.py Outdated Show resolved Hide resolved
osp/serializers/form_feedback.py Outdated Show resolved Hide resolved
Monal5031
Monal5031 suggested changes Aug 15, 2020
View reviewed changes
osp/serializers/form_feedback.py Outdated Show resolved Hide resolved
@bismitaguha
feat: Add models and API for creating, editing & viewing answers for …
177ac63 
…a form

test: Add tests and API docs
feat: Modify conditions in Answer View
feat: Modify read and write serializers for answers and form feedback
feat: Modify Form Feedback read serializer to include values
@Monal5031 Monal5031 merged commit cceab2c into anitab-org:develop Aug 28, 2020
This was referenced Aug 28, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monal5031 Monal5031 Monal5031 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bismitaguha @Monal5031