Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing features on url-wasm #1

Closed
4 of 17 tasks
anonrig opened this issue Feb 20, 2022 · 2 comments
Closed
4 of 17 tasks

Missing features on url-wasm #1

anonrig opened this issue Feb 20, 2022 · 2 comments

Comments

@anonrig
Copy link
Owner

anonrig commented Feb 20, 2022

I've added this issue as a reference for future commiters/contributers. Here's the missing features from the URL-WASM library to be spec compliance.

Documentation

  • Update README and mention url-wasm@alpha for beta testing the application
  • Release an initial benchmark

URLSearchParams

  • new URLSearchParams('hello=world') - @anonrig
  • URLSearchParams encoding checks for compliance - @nebarf
  • URLSearchParams iterator support for entries, keys etc. - @nebarf
  • URLSearchParams.forEach - 3rd parameter is missing. It should return this - @nebarf

URL

  • URL.searchParams should return URLSearchParams instance.
  • URL.hash parsing - @anonrig
  • URL.host parsing
  • URL.hostname parsing
  • URL.href parsing
  • URL.origin parsing
  • URL.password parsing
  • URL.pathname parsing
  • URL.port parsing
  • URL.protocol parsing - @anonrig
  • URL.search parsing (and integrating with URLSearchParams) - @anonrig
@nebarf
Copy link
Contributor

nebarf commented Feb 22, 2022

I'd like to contribute. Do you have any preference/priority? Are you already working on any of the missing features above?

Feel free to reach me in the Node.js Slack channel under my name and surname.

@anonrig
Copy link
Owner Author

anonrig commented Feb 22, 2022

Hi @nebarf,

You can start any of the items from the list. I'll have some time to work on it this weekend and will update the issue before I start any of the tasks. If you tell which issue you're working on, I'll also update the board according to it. Thanks!

@anonrig anonrig closed this as completed May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants