Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress syncronize verbose output #171

Open
phemmer opened this issue Apr 9, 2021 · 3 comments · May be fixed by #220
Open

Suppress syncronize verbose output #171

phemmer opened this issue Apr 9, 2021 · 3 comments · May be fixed by #220
Labels
feature This issue/PR relates to a feature request. has_pr needs_info waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@phemmer
Copy link

phemmer commented Apr 9, 2021

SUMMARY

The synchronize module enables rsync's verbose output. This can flood the output with tons of output. Currently the only option for controlling this is no_log: true. However this suppresses all output, including errors. A mechanism should be provided for suppressing the changes, but still allow showing errors.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

synchronize
@Akasurde
Copy link
Member

Akasurde commented Jun 4, 2021

@phemmer Thanks for reporting this. Do you think adding toggle parameter to enable rsync --quiet option help?

needs_info

@Akasurde Akasurde added feature This issue/PR relates to a feature request. waiting_on_contributor Needs help. Feel free to engage to get things unblocked needs_info labels Jun 4, 2021
@mandar242 mandar242 linked a pull request Jul 12, 2021 that will close this issue
Open
@gravesm
Copy link
Member

gravesm commented Jul 12, 2021

@phemmer Could you check #220 and see if this works for you?

@phemmer
Copy link
Author

phemmer commented Jul 13, 2021 •
edited
Loading

I haven't tested, but If it works, sure. However I thought the module used that output to detect changes (as the same effect can be achieved by removing -v, so I assume -v is there for a reason). But I haven't taken a deep look at the module, so don't know. But it the task properly represents "changed" status, errors are output, and other output is suppressed, then I think that satisfies the requirements.

Edit: It appears the -v is not passed, but becomes implicitly enabled by the usage of --out-format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request. has_pr needs_info waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Synchronize: suppress synchronize verbose output mandar242/ansible.posix
4 participants
@Akasurde @gravesm @phemmer @saito-hideki