Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "type" field to azure_rm_keyvaultsecret #390

Closed
pramos84 opened this issue Jan 10, 2021 · 4 comments
Closed

Add "type" field to azure_rm_keyvaultsecret #390

pramos84 opened this issue Jan 10, 2021 · 4 comments
Labels
has_pr PR fixes have been made medium_priority Medium priority work in In trying to solve, or in working with contributors

Comments

@pramos84
Copy link

SUMMARY

The "type" field in Azure KeyVault resource is like a description of secret or password. I think that add this field to ansible module is a usefull mod that maybe requires a few lines of code. Thanks in advance for all work in this way.

COMPONENT NAME

azure_rm_keyvaultsecret

@Fred-sun
Copy link
Collaborator

@pramos84 Thank you for reporting this request. Could you tell me more details? If so, you want to add a parameter of 'type' to the azure_rm_keyvaultsecret module to describe whether it is a password or a secret? Like this?

@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors labels Jan 11, 2021
@pramos84
Copy link
Author

Hi, Fred-sun. Thanks for your reply. When creating secrets in Azure KeyVault, the Azure Portal shows some fields, like in this example:

image

The "content type" is an optional field, used to describe the secret content. Would be very usefull if we could set the vaule of this field using ansible module. Thanks for helping on this.

@Fred-sun Fred-sun added the has_pr PR fixes have been made label Jan 11, 2021
@Fred-sun
Copy link
Collaborator

@pramos84 I submitted a PR #392 that added the content_type parameter to azure_rm_keyvaultsecret. Please check to see if you can compound your requirements. Thank you very much!

@Fred-sun
Copy link
Collaborator

duplicate with #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has_pr PR fixes have been made medium_priority Medium priority work in In trying to solve, or in working with contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants