Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community.vmware 1.5.0 contained a breaking change #540

Closed
dmsimard opened this issue Dec 1, 2020 · 2 comments · Fixed by #541
Closed

community.vmware 1.5.0 contained a breaking change #540

dmsimard opened this issue Dec 1, 2020 · 2 comments · Fixed by #541

Comments

@dmsimard
Copy link

dmsimard commented Dec 1, 2020

SUMMARY

I've pinged @goneri about it but during the process of releasing Ansible 2.10.4 we found out that community.vmware 1.5.0 included a breaking change, namely: fb1ac77#diff-2c623f3c6a917be56c59d43279244996836262cb1e12d9d0786c9c49eef6b43cR20
Ideally, breaking changes should be reserved for major version releases (such as 2.0) so we don't end up breaking users unexpectedly.

Out of an abundance of caution we included 1.4.0 of community.vmware instead of 1.5.0 in Ansible 2.10.4 but would appreciate advice for the next release.

ISSUE TYPE
  • Bug Report
@goneri
Copy link
Member

goneri commented Dec 2, 2020

Thanks @dmsimard for raising this.

#524 is not a breaking change since we should not have cluster and esxi_hostname in use at the same this the very begining. Sorry for the situation. I don't know how/if we can adjust that now after the release.

Overall, it would be great if the CI can raise a warning when we push a commit with a breaking change.

@dmsimard
Copy link
Author

dmsimard commented Jan 5, 2021

@goneri FYI for the record 1.6.0 shipped in Ansible 2.10.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants