Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul service tags list is error prone #172

Open
rgarrigue opened this issue Sep 10, 2020 · 0 comments
Open

Consul service tags list is error prone #172

rgarrigue opened this issue Sep 10, 2020 · 0 comments

Comments

@rgarrigue
Copy link

Hi there

This is my mistake for reading the doc too quickly, but vault_service_registration_consul_service_tags is a bit misleading : anyone could understand by the name it's a list of tag, hence

vault_service_registration_consul_service_tags:
  - this
  - that

Then boom

image

So maybe allow both format, or add an assert that'll break if it's an array instead of a string ?

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant