This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
Make markdown refs compatible with prettier #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that all our references keys are using lowercase in order to workaround known prettier bug. Related: prettier/prettier#3835 Required-By: ansible#177
ssbarnea
force-pushed
the
fix/prettier-refs
branch
from
9ba4724
to
8666151
Compare
webknjaz
reviewed
Jan 21, 2022
|
|
||
| [CoC]: | ||
| [coc]: |
There was a problem hiding this comment.
I asked you not to do the lowercasing in another PR 🤦♂️ Why did you sneak it in anyway?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that all our references keys are using lowercase in order to workaround known prettier bug.
This is also sorting another issue with editing markdown in vscode itself, which seems to not recognize or highlight the single
[foo]blocks but works well on full ones like[Foo][x]and even inter-linking them.Related: prettier/prettier#3835
Required-By: #177