vmware_host: Small fixes and docs updates #25144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.4
bcoca
removed
the
needs_triage
ansibot
added
stale_ci
This PR includes: - A fix to no longer require a datacenter folder for adding a host - Documentation improvements - Ensure imports are specific
dagwieers
force-pushed
the
vmware_host-fixes
branch
from
1ceba43
to
5f1af13
Compare
ansibot
added
support:core
ansibot
added
community_review
dagwieers
force-pushed
the
vmware_host-fixes
branch
from
e36ab70
to
114877d
Compare
Closed
dagwieers
force-pushed
the
vmware_host-fixes
branch
from
114877d
to
2362f47
Compare
ansibot
added
needs_revision
dagwieers
force-pushed
the
vmware_host-fixes
branch
2 times, most recently
from
e2ee031
to
a48e643
Compare
dagwieers
force-pushed
the
vmware_host-fixes
branch
6 times, most recently
from
c95f522
to
b8b5d31
Compare
Akasurde
requested changes
Jul 20, 2017
| @@ -131,7 +140,10 @@ def process_state(self): | |||
|
|
|||
| def find_host_by_cluster_datacenter(self): | |||
| self.dc = find_datacenter_by_name(self.content, self.datacenter_name) | |||
There was a problem hiding this comment.
Nope, that's the whole point of my PR, self.dc can be None !
| state: | ||
| description: | ||
| - Add or remove the host. | ||
| choices: [absent, present] |
There was a problem hiding this comment.
Indent is required here and below line.
There was a problem hiding this comment.
Yeah, I know, is a man allowed to sleep around here ? :-D
Fix adds following: * Update logic in vmware_host * Update example documentation * Added test case for vmware_host Signed-off-by: Abhijeet Kasurde <[email protected]>
dagwieers
force-pushed
the
vmware_host-fixes
branch
from
b8b5d31
to
61ce9e7
Compare
ansibot
added
community_review
|
shipit |
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR includes:
This fixes #26326 (actually it includes @Akasurde 's changes too, see log below)
Fix adds following:
Signed-off-by: Abhijeet Kasurde [email protected]
ISSUE TYPE
COMPONENT NAME
vmware_host
ANSIBLE VERSION
v2.4