Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_service should support push #33731

Closed
etienned opened this issue Dec 9, 2017 · 15 comments
Closed

docker_service should support push #33731

etienned opened this issue Dec 9, 2017 · 15 comments
Labels
affects_2.4 This issue/PR affects Ansible v2.4 affects_2.5 This issue/PR affects Ansible v2.5 bot_closed cloud collection:community.general collection Related to Ansible Collections work docker feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md support:community This issue/PR relates to code supported by the Ansible community.

Comments

@etienned
Copy link

etienned commented Dec 9, 2017

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

docker_service

ANSIBLE VERSION
ansible 2.4.2.0
CONFIGURATION
OS / ENVIRONMENT

N/A

SUMMARY

docker_service should support push compose command.

In my setup, I'm building images locally, then I push them to a private registry and after that I up my compose app on remote hosts. So I need a way to push newly created images to the registry.

STEPS TO REPRODUCE
  tasks:
    - docker_service:
        project_src: flask
        push: yes

    - docker_service:
        project_src: flask
        push: yes
        build: yes
EXPECTED RESULTS

All locally built images of the compose file are pushed to the registry indicated in each image name like docker-compose push do.

ACTUAL RESULTS

@ansibot
Copy link
Contributor

ansibot commented Dec 9, 2017

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Dec 9, 2017

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 cloud docker feature_idea module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Dec 9, 2017
@alikins alikins added affects_2.5 This issue/PR affects Ansible v2.5 and removed needs_triage Needs a first human triage before being processed. labels Dec 11, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_idea labels Mar 2, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 5, 2018

@ansibot
Copy link
Contributor

ansibot commented Nov 2, 2018

@ansibot
Copy link
Contributor

ansibot commented Dec 12, 2018

@ansibot
Copy link
Contributor

ansibot commented Jan 24, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@felixfontein
Copy link
Contributor

Please note that the docker_service module will be renamed to docker_compose in Ansible 2.8. You will be able to still use the old name, but you will receive a warning when doing so.

!component =lib/ansible/modules/cloud/docker/docker_compose.py

Also, please note that currently, nobody is actively maintaining the Ansible docker_service/docker_compose modules. If you are interested in working on this issue, please feel free to create a PR :) If you need any help, feel free to ping me or any other of the current docker_* module maintainers.

@ansibot
Copy link
Contributor

ansibot commented Feb 4, 2019

@ansibot
Copy link
Contributor

ansibot commented Apr 9, 2019

@ansibot
Copy link
Contributor

ansibot commented Apr 17, 2019

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 17, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 25, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot added module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 25, 2019
@felixfontein
Copy link
Contributor

Out of curiosity: why aren't you using docker_image to push images? (Potentially it didn't support that when you opened this issue.)

needs_info

@ansibot ansibot added the needs_info This issue requires further information. Please answer any outstanding questions. label Jun 8, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 10, 2019

@etienned This issue is waiting for your response. Please respond or the issue will be closed.

click here for bot help

@etienned
Copy link
Author

Sorry for the answering delay. I'm not using docker_image to push images because with this module I'll need to push every images included in my docker compose file one after another. With the push of docker compose, in only one command all images included in my compose file that need to be pushed will be automatically pushed in one shot.

Also, as I'm using docker compose and docker_service is the Ansible's module to work with docker_compose, I find it logical to fullfill all my docker compose's needs with this module. The push command is the only thing missing.

@ansibot ansibot removed the needs_info This issue requires further information. Please answer any outstanding questions. label Jul 16, 2019
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this as completed Aug 16, 2020
@ansible ansible locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 affects_2.5 This issue/PR affects Ansible v2.5 bot_closed cloud collection:community.general collection Related to Ansible Collections work docker feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

No branches or pull requests

4 participants