Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

[Docs] How to review & test a PR #399

Closed
gundalow opened this issue Nov 8, 2018 · 0 comments
Closed

[Docs] How to review & test a PR #399

gundalow opened this issue Nov 8, 2018 · 0 comments
Labels
contributor_experience https://github.com/ansible/community/wiki/Contributor%20Experience

Comments

@gundalow
Copy link
Contributor

gundalow commented Nov 8, 2018

We need (clearer) instructions to so anyone knows how to review and test a PR.

Best type of review is from someone actually using it, rather than just looking at the code,

Ideas generated during Contirbutors Summit

Have we defined what we look for in feedback that's simply for people to follow

Ideas welcome in https://docs.google.com/document/d/1nMevQ0W7MZgJA1tJrJbNHIhTiHYHYUlO3IHXBs_usGE/edit?ts=5be2cd87#heading=h.kzxzqyez5fp5

@gundalow gundalow added the contributor_experience https://github.com/ansible/community/wiki/Contributor%20Experience label Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contributor_experience https://github.com/ansible/community/wiki/Contributor%20Experience
Projects
None yet
Development

No branches or pull requests

2 participants