Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting that treats object_id in DAB RBAC as an integer #450

Open
AlanCoding opened this issue Jun 11, 2024 · 0 comments
Open

Add a setting that treats object_id in DAB RBAC as an integer #450

AlanCoding opened this issue Jun 11, 2024 · 0 comments
Labels
api API related item app:rbac app:resource_registry enhancement New feature or request

Comments

@AlanCoding
Copy link
Member

Proposal:

Introduce a new setting in the DAB RBAC section that specifies:

Treat the object_id field (local ids for references) as an integer field in the API

Internally, we may continue to use a string type indefinitely for consistency with resource registry and to support uuids. However, many apps have no need to support uuid primary keys. For those, it may cause fewer problems for clients to have the object_id, as presented in the API, to be an integer.

This is fairly straightforward to implement. Although serializers may derive type from the model, this is trivial to override to a nullable integer field in the serializer. I don't desire that test_app use this setting by default, but we should have tests for this.

It is unclear if we should have something similar for resource registry.

@AlanCoding AlanCoding added enhancement New feature or request api API related item app:resource_registry app:rbac labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API related item app:rbac app:resource_registry enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant