Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molecule 3.0 pre-release check list #2067

Closed
4 tasks
decentral1se opened this issue May 25, 2019 · 10 comments
Closed
4 tasks

Molecule 3.0 pre-release check list #2067

decentral1se opened this issue May 25, 2019 · 10 comments

Comments

@decentral1se
Copy link
Contributor

decentral1se commented May 25, 2019

OK, let's have it, what do we need?

@decentral1se
Copy link
Contributor Author

RE: ansible verifier, from a quick check, generating a new role still does have the testinfra configuration in place and the pytest files there. We should change that around. Perhaps a new default ansible verifier file with the same host check as testinfra?

@znerol
Copy link
Contributor

znerol commented May 28, 2019

I'd really love to see a 2.x (pre-)release before/now which is compatible with ansible 2.8. Is there any way I can help to make this happen?

@ssbarnea ssbarnea changed the title Molecule 3.0 pre-releas check list Molecule 3.0 pre-release check list May 28, 2019
@decentral1se
Copy link
Contributor Author

@znerol, this is a Good Idea. I'm working on closing those critical bugs listed above and then I will try to get this next 2.X release out with Ansible 2.8 support. This will be good actually to get more feedback. Ansible will not be the default verifier but available for use.

@MarkusTeufelberger
Copy link
Contributor

I don't see something so far that would warrant increasing the major release number.

@decentral1se
Copy link
Contributor Author

I don't see something so far that would warrant increasing the major release number.

New default verifier is Ansible.

@MarkusTeufelberger
Copy link
Contributor

That's a minor detail in a template that gets rendered, no API change.

@decentral1se
Copy link
Contributor Author

Molecule is not a regular library. The "API" is that you get testinfra as the default verifier on 2.X and on 3.X you have new a default verifier. On newly generated templates, you'll have to switch the configuration to use testinfra if that is what you want. That is a "breaking API change". This is following a number of people +1'ing the idea of 3.0 release on a recent WG meeting.

@MarkusTeufelberger
Copy link
Contributor

Molecule 1 --> 2 was a major rewrite. Molecule 2 --> 3 happens because a default value in molecule init role changes? Also I'd like to see at least 2-3 releases with the Ansible verifier as non-default option to find out if it might even make sense to keep around. Ansible is not a verification tool.

@decentral1se
Copy link
Contributor Author

I've got better things to be doing.

@tehsmyers
Copy link
Contributor

ansible is currently not the default verifier; the PR to make ansible the default verifier (#2013) was closed without merging. I also just tested molecule init role on latest master and it's still using testinfra as expected.

If changing the default verifier was the main reason for considering a major version bump, should this issue be reopened and renamed to reference molecule 2.21, or should a new issue be created?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants