Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename commit-style to something related to pull request name #571

Closed
germa89 opened this issue Sep 23, 2024 · 5 comments · Fixed by #578
Closed

Rename commit-style to something related to pull request name #571

germa89 opened this issue Sep 23, 2024 · 5 comments · Fixed by #578
Milestone
v8

Comments

@germa89
Copy link
Contributor

germa89 commented Sep 23, 2024

Currently the action commit-style does not check the commit, but the pull request name.

https://github.com/ansys/actions/blob/release/7.0/commit-style/action.yml

Hence, I would propose to rename it something like:

ansys/actions/pullrequest-name or similar... I actually dont care much, but the name is confusing.
@germa89
Copy link
Contributor Author

germa89 commented Sep 23, 2024

Pinging @klmcadams @RobPasMue

@klmcadams
Copy link
Contributor

klmcadams commented Sep 23, 2024 •
edited
Loading

I agree, maybe we could make it ansys/actions/check-pr-name, check-pr-title, or check-conventional-commits? I'm thinking check-pr-title may be the best

@RobPasMue
Copy link
Member

RobPasMue commented Sep 23, 2024 •
edited
Loading

Completely agreed - could we do this with the v8 change @ansys/pyansys-core? My vote goes for check-pr-title

@SMoraisAnsys
Copy link
Contributor

Agreed and voting for check-pr-title :)

@MaxJPRey
Copy link
Contributor

+1 for check-pr-title.

@jorgepiloto jorgepiloto added this to the v8 milestone Sep 24, 2024
@jorgepiloto jorgepiloto mentioned this issue Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8
Development

Successfully merging a pull request may close this issue.

fix: rename commit-sytle -> check-pr-title ansys/actions
6 participants
@germa89 @jorgepiloto @RobPasMue @klmcadams @MaxJPRey @SMoraisAnsys