Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash scripts are currently unrecognized since the there is no file extension #101

Open
dipinknair opened this issue Dec 22, 2023 · 2 comments
Assignees
Labels
enhancement New features or code improvements

Comments

@dipinknair
Copy link

📝 Description of the feature

Bash scripts are failing in pre-commit license because of it does not have extension and hence error is coming as unrecognized file.

Skipped unrecognised file D:\PyAnsys\Repos\pymechanical-env\src\ansys\mechanical\env\mechanical-env

eg: mechanical-env
https://github.com/ansys/pymechanical-env/blob/main/src/ansys/mechanical/env/mechanical-env

💡 Steps for implementing the feature

It can be fixed or we can exclude files using exclude option and manually update license

🔗 Useful links and references

No response

@dipinknair dipinknair added the enhancement New features or code improvements label Dec 22, 2023
@RobPasMue
Copy link
Member

RobPasMue commented Jan 2, 2024

I don't believe this is the hook's issue. The main problem is that the file has no extension. All files should have extensions (except for binaries on Linux IMO).

@RobPasMue
Copy link
Member

My only suggestion is that we also enable a way to pass in a file location explicitly, and we assume that whatever file passed is in ASCII.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

No branches or pull requests

3 participants