Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default args in pre-commit-hooks.yaml #11

Closed
klmcadams opened this issue Jul 21, 2023 · 3 comments · Fixed by #23
Closed

Default args in pre-commit-hooks.yaml #11

klmcadams opened this issue Jul 21, 2023 · 3 comments · Fixed by #23
Assignees
@klmcadams
Labels
enhancement New features or code improvements

Comments

@klmcadams
Copy link
Contributor

📝 Description of the feature

Pass all sys.args to get_args() to avoid the default definition "args: ["--loc=src"]" in .pre-commit-hooks.yaml. Only put default --loc value in argparse

💡 Steps for implementing the feature

No response

🔗 Useful links and references

No response
@klmcadams klmcadams added the enhancement New features or code improvements label Jul 21, 2023
@klmcadams klmcadams self-assigned this Jul 21, 2023
@RobPasMue
Copy link
Member

Does this one still apply @klmcadams ?

@RobPasMue
Copy link
Member

RobPasMue commented Aug 3, 2023 •
edited
Loading

Ah yes... clean up of the hook itself. Try working on that. Should be fairly straightforward

@RobPasMue
Copy link
Member

Basically deleting https://github.com/ansys/pre-commit-hooks/blob/main/.pre-commit-hooks.yaml#L5

@klmcadams klmcadams mentioned this issue Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klmcadams klmcadams

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed default args in pre-commit-hooks.yaml ansys/pre-commit-hooks
2 participants
@RobPasMue @klmcadams