Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Hfss.wave_port() #3423

Closed
2 tasks done
Devin-Crawford opened this issue Aug 16, 2023 · 3 comments
Closed
2 tasks done

Bug in Hfss.wave_port() #3423

Devin-Crawford opened this issue Aug 16, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Devin-Crawford
Copy link
Contributor

Before submitting the issue

  • I have searched among the existing issues
  • I am using a Python virtual environment

Description of the bug

Hfss.wave_port() fails when the first passed argument is an instance of pyaedt.modeler.elements3d.FacePrimitive.

In hfss.py on line 6247

sheet_name = self.modeler.convert_to_selections(signal, True)[0]

returns the name of the 3D primitive to which FacePrimitive belongs. This ends up assigning the name of the 3d object to the variable face on line 6274.

Steps To Reproduce

Pass a FacePrimitive that belongs to a 3d primitive to Hfss.wave_port()

Will assign this to myself.

Which Operating System are you using?

Windows

Which Python version are you using?

3.10

Installed packages

Full PyAedt dependencies installed.

@Devin-Crawford Devin-Crawford added the bug Something isn't working label Aug 16, 2023
@Devin-Crawford Devin-Crawford self-assigned this Aug 16, 2023
@Devin-Crawford
Copy link
Contributor Author

Automatic PEC creation gets the wrong type of argument when face is a 3D Object (line 6279 of hfss.py):

self._create_pec_cap(face, signal, -dist / 10)

@Devin-Crawford
Copy link
Contributor Author

Need to add support for the native API:

oModule.AutoIdentifyPorts(
	[
		"NAME:Faces", 
		269
	], True, 
	[
		"NAME:ReferenceConductors"
	], "1", True)
oModule.AutoCreatePECCapForWavePort(
	[
		"NAME:AutoCreatePECCapForWavePort",
		"Wave Port Name:="	, "1",
		"Face ID:="		, 269,
		"Thickness:="		, "0.5mm",
		"Flip Side:="		, False,
		"Cover Holes:="		, True
	])

@Devin-Crawford
Copy link
Contributor Author

Resolved in PR #3566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant