Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Compute Exact DC Point" functionality to siwave SYZ sweep #3560

Closed
pyAnsysUser opened this issue Sep 13, 2023 · 4 comments · Fixed by #3840
Closed

Add "Compute Exact DC Point" functionality to siwave SYZ sweep #3560

pyAnsysUser opened this issue Sep 13, 2023 · 4 comments · Fixed by #3840
Assignees
Labels
enhancement New features or code improvements

Comments

@pyAnsysUser
Copy link
Contributor

Description of the feature

Computing exact DC point enables high accuracy PDN analysis through API

Steps for implementing the feature

Since causality and exact DC are mutually exclusive, I expecting enabling one disables the other. There may be an associated message with this. This may steer the implementation since I do not see if the causality option is documented as accessible though API either.

Useful links and references

ScrSIwaveSyzComputeExactDcPoint()
ScrSIwaveSyzEnforceCausality()

@pyAnsysUser pyAnsysUser added the enhancement New features or code improvements label Sep 13, 2023
@hui-zhou-a hui-zhou-a added the edb label Oct 27, 2023
@hui-zhou-a hui-zhou-a self-assigned this Oct 27, 2023
@hui-zhou-a
Copy link
Contributor

@pyAnsysUser you can set compute_dc_point after the PR is merged.

sweep = setup1.add_frequency_sweep(
            "sweep1",
            frequency_sweep=[
                ["linear count", "0", "1kHz", 1],
                ["log scale", "1kHz", "0.1GHz", 10],
                ["linear scale", "0.1GHz", "10GHz", "0.1GHz"],
            ],
        )
sweep.compute_dc_point = True

@hui-zhou-a hui-zhou-a linked a pull request Nov 6, 2023 that will close this issue
@pyAnsysUser
Copy link
Contributor Author

This is an excellent addition, thank you!

@pyAnsysUser
Copy link
Contributor Author

pyAnsysUser commented Nov 7, 2023

@ring630 what is expected outcome of the line:
["linear count", "0", "1kHz", 1],
I see a linear count with two frequencies but a single output point as ambiguous- I know that this is the way it is in the documentation, but is this better than
["linear count", "0", "0", 1],
or
["linear count", "1kHz", "1kHz", 1],

@hui-zhou-a
Copy link
Contributor

@pyAnsysUser it will add 0hz in the frequency list.

["linear count", "0", "0", 1] also works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants