Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant keyword arguments when creating primitives. #4018

Closed
Devin-Crawford opened this issue Dec 29, 2023 · 2 comments · Fixed by #4019
Closed

Remove redundant keyword arguments when creating primitives. #4018

Devin-Crawford opened this issue Dec 29, 2023 · 2 comments · Fixed by #4019
Assignees
@Devin-Crawford
Labels
enhancement New features or code improvements

Comments

@Devin-Crawford
Copy link
Contributor

Description of the feature

Resolution of issue #4010 makes some keyword arguments for primitives obsolete. For example, app.modeler.create_rectangle(matname="Copper") can be replaced by app.modeler.create_rectangle(material_name).

Steps for implementing the feature

The method GeometryModeler._create_object() will map variable keyword arguments to their corresponding properties.

Useful links and references

No response
@Devin-Crawford Devin-Crawford added the enhancement New features or code improvements label Dec 29, 2023
@Devin-Crawford Devin-Crawford self-assigned this Dec 29, 2023
@Devin-Crawford
Copy link
Contributor Author

Addressed in PR #4019.

@gmalinve gmalinve linked a pull request Jan 3, 2024 that will close this issue
Feat/4010 pass primitive features #4019
Merged
@gmalinve
Copy link
Contributor

gmalinve commented Jan 3, 2024

Closed by #4019.

@gmalinve gmalinve closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Devin-Crawford Devin-Crawford

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/4010 pass primitive features ansys/pyaedt
2 participants
@Devin-Crawford @gmalinve