From d4cb22065a1b3c6482313286699610c7242494c2 Mon Sep 17 00:00:00 2001 From: Lorenzo Vecchietti Date: Mon, 6 May 2024 12:13:45 +0200 Subject: [PATCH 1/4] improve error handling --- pyaedt/modules/MeshIcepak.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/pyaedt/modules/MeshIcepak.py b/pyaedt/modules/MeshIcepak.py index 985df51ee86..a962deb89ad 100644 --- a/pyaedt/modules/MeshIcepak.py +++ b/pyaedt/modules/MeshIcepak.py @@ -1067,8 +1067,12 @@ def _get_design_mesh_operations(self): "Icepak", ) ) - except Exception as e: - self._app.logger.error(e) + except TypeError: + # design_properties not loaded, maybe there are mesh op, we need to warn the user + self._app.logger.warning("No mesh operation found.") + except KeyError: + # design_properties loaded, mesh op keys missing, no need to warn the user + pass return meshops @@ -1104,8 +1108,9 @@ def _get_design_mesh_regions(self): if el in meshop.__dict__: meshop.__dict__[el] = dict_prop[el] meshops.append(meshop) - except Exception as e: - self._app.logger.error(e) + except TypeError: + # design_properties not loaded, maybe there are mesh op, we need to warn the user + self._app.logger.warning("No mesh region found.") return meshops From 656efbc064ded6f3dab441cc4475db98d0722b87 Mon Sep 17 00:00:00 2001 From: Lorenzo Vecchietti Date: Mon, 6 May 2024 12:28:30 +0200 Subject: [PATCH 2/4] better error handling for 3d comp --- pyaedt/modeler/modeler3d.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyaedt/modeler/modeler3d.py b/pyaedt/modeler/modeler3d.py index 590a94e0420..9ce11f8de8c 100644 --- a/pyaedt/modeler/modeler3d.py +++ b/pyaedt/modeler/modeler3d.py @@ -215,7 +215,7 @@ def create_3dcomponent( else: native_objs = [obj.name for _, v in self.user_defined_components.items() for _, obj in v.parts.items()] objs = [obj for obj in self.object_names if obj not in native_objs] - if not native_components and native_objs: + if not native_components and native_objs and not auxiliary_dict: self.logger.warning( "Native component objects cannot be exported. Use native_components argument to" " export an auxiliary dictionary file containing 3D components information" From 216b13252d9aedccf47b3ed418d427d4eb894827 Mon Sep 17 00:00:00 2001 From: Lorenzo Vecchietti Date: Mon, 6 May 2024 15:35:09 +0200 Subject: [PATCH 3/4] fix for mesh region except --- pyaedt/modules/MeshIcepak.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pyaedt/modules/MeshIcepak.py b/pyaedt/modules/MeshIcepak.py index a962deb89ad..e4e87f1bb93 100644 --- a/pyaedt/modules/MeshIcepak.py +++ b/pyaedt/modules/MeshIcepak.py @@ -1111,6 +1111,9 @@ def _get_design_mesh_regions(self): except TypeError: # design_properties not loaded, maybe there are mesh op, we need to warn the user self._app.logger.warning("No mesh region found.") + except KeyError: + # design_properties loaded, mesh op keys missing, no need to warn the user + pass return meshops From a9d8824b9547bfe5012d3544e78e7fea1ffad539 Mon Sep 17 00:00:00 2001 From: Lorenzo Vecchietti Date: Mon, 6 May 2024 17:23:30 +0200 Subject: [PATCH 4/4] Update messages --- pyaedt/modules/MeshIcepak.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/pyaedt/modules/MeshIcepak.py b/pyaedt/modules/MeshIcepak.py index e4e87f1bb93..4091f62429b 100644 --- a/pyaedt/modules/MeshIcepak.py +++ b/pyaedt/modules/MeshIcepak.py @@ -1068,11 +1068,12 @@ def _get_design_mesh_operations(self): ) ) except TypeError: - # design_properties not loaded, maybe there are mesh op, we need to warn the user + # design_properties not loaded, maybe there are mesh region, we need to warn the user self._app.logger.warning("No mesh operation found.") + self._app.logger.debug("Failed to get mesh operation from `design_properties`.") except KeyError: - # design_properties loaded, mesh op keys missing, no need to warn the user - pass + # design_properties loaded, mesh region related keys missing, no need to warn the user + self._app.logger.debug("Failed to get mesh operation.") return meshops @@ -1109,11 +1110,12 @@ def _get_design_mesh_regions(self): meshop.__dict__[el] = dict_prop[el] meshops.append(meshop) except TypeError: - # design_properties not loaded, maybe there are mesh op, we need to warn the user + # design_properties not loaded, maybe there are mesh region, we need to warn the user self._app.logger.warning("No mesh region found.") + self._app.logger.debug("Failed to get mesh region from `design_properties`.") except KeyError: - # design_properties loaded, mesh op keys missing, no need to warn the user - pass + # design_properties loaded, mesh region related keys missing, no need to warn the user + self._app.logger.debug("Failed to get mesh region.") return meshops