-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the addition and maintenance of new projects #755
Comments
I raised my concerns to @jorgepiloto yesterday... I don't think this is a good idea since it will make this Python package to no longer work as a normal, modern Python package, and also dependabot will probably stop working properly... I know it is time consuming and implies touching a lot of places whenever a new library is added but I wouldn't move from pyproject.toml to setup.py. Most of the affected files are typically in the docs. We could restrict this "new file" approach only to the documentation if you prefer but still, there are many nuances to take into account... |
Agreed, this is a step backwards with respect to this being a modern Python package. As a simple quality-of-life improvement, a pre-commit hook which either checks or updates the various places (taking |
Yep I agree! That would be a much easier way to handle it. Or a dedicated script that you just run when you need to add a new library. |
Something closer to the original suggestion which I'd also consider workable is:
So worst case, you would have to add the library in two places ( |
Works too =) |
Thank you both for your valuable inputs @greschd and @RobPasMue. We will start exploring doing this in a way similar to your suggestions. Once the final solution becomes available, I will tag you both for additional inputs. |
Let's start by creating the YML file: projects:
pymapdl:
name: ...
repository: ...
thumbnail: ...
...
We'll read this from the |
A number of files (e.g. pyproject.toml, links.py, examples.rst to name a few) have to be edited manually each time there is a new addition/subtraction to/from the pyansys metapackage. This issue will address removing this manual process by:
The text was updated successfully, but these errors were encountered: