Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing pre-commit.ci #1253

Closed
RobPasMue opened this issue Jan 11, 2023 · 1 comment · Fixed by #1254
Closed

Implementing pre-commit.ci #1253

RobPasMue opened this issue Jan 11, 2023 · 1 comment · Fixed by #1254
Assignees

Comments

@RobPasMue
Copy link
Member

RobPasMue commented Jan 11, 2023

Hi @seanpearsonuk @dnwillia!

We have been recently implementing a tool called pre-commit.ci in several PyAnsys repositories. This tool is characterized for the following:

  • It allows us to "get rid" of the pre-commit stage of our own workflows in favor of using a third-party tool
  • This tool then runs pre-commit on its own cached resources, allowing for faster run times of pre-commit
  • If the tool detects a pre-commit failure, it creates a commit to try and fix the issue encountered (this only occurs if the pre-commit hook that failed is able to reformat)
  • It maintains the pre-commit hook versions updated (which by the way, dependabot does not).
  • It also provides the repository with a new badge for its main README informing of the status of pre-commit on its latest run.

PyMAPDL, PyAEDT and the PyAnsys metapackage, among others, have already migrated to this tool. If you agree as well on its use, I'd be happy to implement it on your repositories:

  • PyFluent
  • PyFluentVisualization
  • PyFluentParametric
@seanpearsonuk
Copy link
Collaborator

Hi @RobPasMue. Many this for this, it sounds like a nice improvement. Please proceed whenever convenient for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants