Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer 4.22.1 breaks width="500" usage #36754

Closed
afc163 opened this issue Jul 28, 2022 · 2 comments · Fixed by react-component/drawer#284
Closed

Drawer 4.22.1 breaks width="500" usage #36754

afc163 opened this issue Jul 28, 2022 · 2 comments · Fixed by react-component/drawer#284
Assignees
@zombieJ

Comments

@afc163
Copy link
Member

afc163 commented Jul 28, 2022 •
edited
Loading

  1. 这不是规范的用法，应该是 width="500px" 或者 width={500}，这是 React 的约定，但文档还是可以写清楚。
  2. 4.21.7 版本确实支持，比较诡异。https://codesandbox.io/s/ji-chu-chou-ti-antd-4-22-1-forked-2lqmdu?file=/demo.js 看上去还是得做个兼容。
@afc163
Copy link
Member Author

afc163 commented Jul 28, 2022

文档的 PR：#36753

@legend80s
Copy link

确实需要兼容 否则就是 break change

This was referenced Jul 28, 2022
Closed
Closed
@zombieJ zombieJ mentioned this issue Jul 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zombieJ zombieJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Not break string size but warning react-component/drawer
3 participants
@afc163 @zombieJ @legend80s