Skip to content

Commit

Permalink
🐛 fix: 修正 message、notification 组件 prefix 不对的问题
Browse files Browse the repository at this point in the history
  • Loading branch information
arvinxx committed Jan 17, 2023
1 parent 94e569f commit 01380ee
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
14 changes: 6 additions & 8 deletions src/containers/ThemeProvider/AntdProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,12 @@ const AntdProvider: FC<AntdProviderProps> = memo(
({ children, theme: themeProp, prefixCls, getStaticInstance, staticInstanceConfig }) => {
const { appearance, isDarkMode } = useThemeMode();

const [messageInstance, messageContextHolder] = message.useMessage({
prefixCls,
...(staticInstanceConfig?.message || {}),
});
const [notificationInstance, notificationContextHolder] = notification.useNotification({
prefixCls,
...(staticInstanceConfig?.notification || {}),
});
const [messageInstance, messageContextHolder] = message.useMessage(
staticInstanceConfig?.message,
);
const [notificationInstance, notificationContextHolder] = notification.useNotification(
staticInstanceConfig?.notification,
);
const [modalInstance, modalContextHolder] = Modal.useModal();

useEffect(() => {
Expand Down
6 changes: 3 additions & 3 deletions tests/containers/ThemeProvider.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ describe('ThemeProvider', () => {
}}
staticInstanceConfig={{
message: {
maxCount: 1,
getContainer: () => document.getElementById('xxx')!,
},
notification: {
Expand All @@ -270,13 +271,12 @@ describe('ThemeProvider', () => {
message.success('success');
});

expect(container.getElementsByClassName('demo-notice-success')).toHaveLength(1);
expect(container.getElementsByClassName('demo-message')).toHaveLength(1);

act(() => {
notification.warning({ message: '123' });
});

expect(container.getElementsByClassName('demo-notice-warning')).toHaveLength(1);
expect(container.getElementsByClassName('demo-notice')).toHaveLength(2);
expect(container.getElementsByClassName('demo-notification')).toHaveLength(1);
});
});

0 comments on commit 01380ee

Please sign in to comment.