Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly support when finality advances multiple blocks at a time. #131

Merged
merged 3 commits into from
May 13, 2024
Merged

Correctly support when finality advances multiple blocks at a time. #131

merged 3 commits into from
May 13, 2024

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented May 10, 2024 •
edited
Loading

In that case, duplicate policies can become pending for the same block.

Resolves #130.

Also added a test which demonstrates the issue when the fix is not present.

@greg7mdp greg7mdp requested review from heifner and linh2931 May 13, 2024 15:26
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Resolves duplicate polices from advancing. Finality can advance multiple blocks, previously this may cause duplicate policies to advance.
Note:end

@greg7mdp greg7mdp merged commit 61425c1 into main May 13, 2024
36 checks passed
@greg7mdp greg7mdp deleted the gh_130 branch May 13, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@greg7mdp @ericpassmore @heifner @linh2931