Provide finalizer policy in SHiP finality_data only when it gets promoted to pending #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
Jun 27, 2024
greg7mdp
reviewed
Jun 27, 2024
greg7mdp
reviewed
Jun 27, 2024
…e_directories such that local headers can be included using <>; use #include <finality_test_cluster.hpp> in block_state_tests.cpp
heifner
approved these changes
Jun 27, 2024
greg7mdp
reviewed
Jun 27, 2024
unittests/block_state_tests.cpp
Outdated
| // Produce one more block. The proposed finalizer policy is promoted to pending in this block. | ||
| // We should see pending_finalizer_policy in finality_data | ||
| produce_and_push_block(); | ||
| process_votes(1, num_nodes - 1); // all non-producing nodes (staring from node1) vote |
There was a problem hiding this comment.
Suggested change
| process_votes(1, num_nodes - 1); // all non-producing nodes (staring from node1) vote | |
| process_votes(1, num_nodes - 1); // all non-producing nodes (starting from node1) vote |
There was a problem hiding this comment.
Sorry I missed those two. Thanks. Fixed.
greg7mdp
reviewed
Jun 27, 2024
unittests/block_state_tests.cpp
Outdated
| // Produce another block. We should not see pending_finalizer_policy as | ||
| // no proposed finalizer policy is promoted to pending in this block | ||
| produce_and_push_block(); | ||
| process_votes(1, num_nodes - 1); // all non-producing nodes (staring from node1) vote |
There was a problem hiding this comment.
Suggested change
| process_votes(1, num_nodes - 1); // all non-producing nodes (staring from node1) vote | |
| process_votes(1, num_nodes - 1); // all non-producing nodes (starting from node1) vote |
greg7mdp
approved these changes
Jun 27, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHiP
finality_datashould only include the finalizer policy when it goes from proposed to pending. This PR renames the existing fieldfinality_data_t::proposed_finalizer_policytofinality_data_t::pending_finalizer_policy(but keeping the same type std::optional<finalizer_policy>) to capture the semantic change, and changes the logic to include the finalizer policy only when it goes from proposed to pendingAdds a test to check pending_finalizer_policy in finality_data.
AntelopeIO/abieos#32 is created in abieos repo for corresponding SHiP protocol changes.
Resolves #320