Add timestamp and parent_timestamp to finality leaf nodes.
#392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
approved these changes
Jul 24, 2024
…oint, adapted savanna smart contract + IBC tests
|
Note:start |
systemzax
added
the
consensus-protocol
heifner
requested changes
Jul 24, 2024
heifner
reviewed
Jul 24, 2024
heifner
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each finality leaf node commits to that block's timestamp (called
timestamp), and also the timestamp of the parent block as well (calledparent_timestamp). This data is always accessible from thefinality_core(except for the genesis block). For the genesis block, theparent_timestampis simply be the the earliest representable timestamp.IBC unit tests have been updated to that this addition into account (thanks Guillaume!).