Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0-beta4 -> main] Remove last_final_block_timestamp from fork choice rule #445

Merged
merged 3 commits into from
Jul 30, 2024
Merged

[1.0-beta4 -> main] Remove last_final_block_timestamp from fork choice rule #445

merged 3 commits into from
Jul 30, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jul 30, 2024

Remove last_final_block_timestamp from fork choice rule which can prevent a switch to a fork with a locked block to extend via safety.

Merges release/1.0-beta4 into main including #441

@heifner heifner changed the title [1.0-beta4 -> main] Remove last_final_block_timestamp from fork choice rul [1.0-beta4 -> main] Remove last_final_block_timestamp from fork choice rule Jul 30, 2024
@heifner heifner merged commit cd8b458 into main Jul 30, 2024
36 checks passed
@heifner heifner deleted the fork-choice-rule-main branch July 30, 2024 19:46
@heifner heifner linked an issue Jul 30, 2024 that may be closed by this pull request
Remove last_final_block_timestamp from fork choice rule #446
Closed
@heifner heifner added the OCI Work exclusive to OCI team label Jul 30, 2024
@ericpassmore
Copy link
Contributor

ericpassmore commented Aug 1, 2024 •
edited
Loading

Note:start
group: STABILITY
category: INTERNALS
summary: Update logic to use latest timestamp to pick winning fork, previously used block height.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove last_final_block_timestamp from fork choice rule
4 participants
@heifner @ericpassmore @greg7mdp @linh2931