fix(element-ui): unexpected handling of components #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
approved these changes
Feb 15, 2022
sxzz
changed the title
ascott18
pushed a commit
to ascott18/unplugin-vue-components
that referenced
this pull request
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually an extension of this modification: af8a7a0#diff-0b83587ef377a4d009821193cbfa7413273d34fddfdafc110049fe72eac51785R74-L24
Currently
ElementUiResolveraccidentally handles components with names likeElegantComponentjust because their names start withEl. I've been unable to determine the circumstances under which the commit mentioned above was made, but it appears thatElementUiResolverwas missed at the time.As an aside, in the future, perhaps options such as
excludewill have the ability to be ported toElementUiResolver, but that is not what this PR is intended to discuss.