Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential integer overflow in sds.c #150

Open
Crispy-fried-chicken opened this issue Feb 3, 2024 · 0 comments
Open

Potential integer overflow in sds.c #150

Crispy-fried-chicken opened this issue Feb 3, 2024 · 0 comments

Comments

@Crispy-fried-chicken
Copy link

Crispy-fried-chicken commented Feb 3, 2024

The sdsnewlen and sdsMakeRoomFor function implemented in sds.c is quite similiar to those in the redis. Thus, it's very likely that this integer overflow in CVE-2021-21309 also affects sds.
Would you can help to check if this bug is true? If it's true, I'd like to open a PR for that if necessary. Thank you for your effort and patience!
And here is the patch for CVE-2021-21309 for your reference if this issue needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant