Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members of group cache for multicast are never deleted #4175

Closed
hongliangl opened this issue Aug 30, 2022 · 0 comments · Fixed by #4176
Closed

Members of group cache for multicast are never deleted #4175

hongliangl opened this issue Aug 30, 2022 · 0 comments · Fixed by #4176
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@hongliangl
Copy link
Contributor

In pkg/agent/multicast/mcast_controller.go, we can see that UninstallGroup is called to uninstall a group for multicast, but in pkg/agent/openflow/client.go:

func (c *client) UninstallGroup(groupID binding.GroupIDType) error {
	c.replayMutex.RLock()
	defer c.replayMutex.RUnlock()
	if err := c.bridge.DeleteGroup(groupID); err != nil {
		return fmt.Errorf("error when deleting Service Endpoints Group: %v", err)
	}
	c.featureService.groupCache.Delete(groupID)
	return nil
}

We can see that only group cache for Service is manipulated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants