-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add env 'ANTREA_NAMESPACE' support in antctl #6131
Comments
I wonder why this is not caught by antrea/test/e2e/antctl_test.go Line 184 in df82b76
The test Pod which runs antctl is created in the "test namespace", not in the kube-system namespace. |
I would like to work on this issue, Lan and Antonin! |
Hi @roopeshsn I have assigned this issue to you, thanks for your interest to contribution. |
Is this issue being solved? I would like to solve this issue |
@EraKin575 you are welcome to submit a PR, given that we have not heard back from @roopeshsn |
Hi, @antoninbas! I am working on this issue. Apologies for not replying in a timely manner. I'll come up with progress in a week. |
After looking at the code it seems, the GetControllerCACert function is getting the CA cert from the antrea/pkg/antctl/raw/helper.go Line 88 in 3ac87f6
But I need more context on what should be done. I am still unclear about where the user configures the namespace that the Antrea should deployed to (In the CRD or ConfigMap or somewhere else). Your hints help @luolanzone |
Hi, @luolanzone @antoninbas! Your input will help me to move forward. |
Hi @roopeshsn sorry for late response, there are a few ways to deploy Antrea. One way is through Helm chart, here is the guide. https://github.com/antrea-io/antrea/blob/main/docs/helm.md#installation. Users can change the Namespace in this command Usually it's |
Hi @roopeshsn Thanks for your efforts to checking this issue, but I didn't see any response from your side for a long time, I will reassign this. @shikharish |
Looks like the line in this patch https://github.com/antrea-io/antrea/pull/6037/files#diff-021261b9b4b17757daf50089685c69e22c4cc1d0c350b5571e85226d7fe51c52R89 already fixed the issue without introducing a new variable |
@roopeshsn I know you are still trying to fix the issue, however, looks like the bug is not longer existing after the patch. Thanks a lot for your efforts. I will close this issue considering it's no longer valid. |
After this #5135 change is introduced, when antctl is called in a Pod (e.g. named
debug
) to collect Antrea support bundle in a secure way, it will get the Namespace of thedebug
Pod instead of Antrea Pod's Namespace. If thedebug
Pod is not running inkube-system
, it will fail to get Antrea CA config which is located atkube-system
.To avoid such Namespace mismatch issue, it would be better to add a new env like
ANTREA_NAMESPACE
in antctl to allow user to configure which Namespace the Antrea is deployed to.The text was updated successfully, but these errors were encountered: