Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bind minimap plugin to graph without scroller #4167

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

Indigo-w
Copy link
Collaborator

Description

bind minimap plugin to graph without scroller

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot
Copy link
Contributor

x6-bot bot commented Jan 19, 2024

👋 @Indigo-w

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@x6-bot x6-bot bot added PR(fix) :bug: Bug Fix size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. PR: unreviewed PR does not have any reviews. labels Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12ca0e1) 10.37% compared to head (71753b9) 10.36%.
Report is 33 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4167      +/-   ##
==========================================
- Coverage   10.37%   10.36%   -0.02%     
==========================================
  Files         180      180              
  Lines       10542    10563      +21     
  Branches     2566     2572       +6     
==========================================
+ Hits         1094     1095       +1     
- Misses       9359     9379      +20     
  Partials       89       89              
Flag Coverage Δ
x6 10.36% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@NewByVector NewByVector merged commit f6475ac into master Jan 23, 2024
17 checks passed
@NewByVector NewByVector deleted the fix/minimap branch January 23, 2024 11:08
@x6-bot x6-bot bot added PR: reviewed-approved PR has reviewed and got Approve from everyone. and removed PR: unreviewed PR does not have any reviews. labels Jan 23, 2024
@x6-bot
Copy link
Contributor

x6-bot bot commented Jan 23, 2024

👋 @Indigo-w

Congrats on merging your first pull request! 🎉🎉🎉

@x6-bot x6-bot bot added the PR: merged PR has merged. label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR(fix) :bug: Bug Fix PR: merged PR has merged. PR: reviewed-approved PR has reviewed and got Approve from everyone. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants