chore(view-recursive): add warning message before refactor #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hustcc
commented
Aug 24, 2020
hustcc
commented
- 增加 warning message 多 view 嵌套
simaQ
approved these changes
Aug 25, 2020
| // 这个 API 理论上用户量不多，所以暂时不发大版本，所以先暂时打一个 warning。 | ||
| if (this.parent && this.parent.parent) { | ||
| // 存在 3 层 结构了 | ||
| console.warn('The view nesting recursive feature will be removed at G2 V4.1. Please avoid to use it.'); |
There was a problem hiding this comment.
感觉最后还是应该升一个大版本，可以以这次 930 为节点，G2Plot 1.0 的功能点迁移完 + G2 体验优化点基本完成。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.