Skip to content
This repository has been archived by the owner. It is now read-only.

[dashboard]integrate new ad hoc time picker in native dashboard #104

Closed
junlincc opened this issue Dec 19, 2020 · 5 comments
Closed

[dashboard]integrate new ad hoc time picker in native dashboard #104

junlincc opened this issue Dec 19, 2020 · 5 comments

Comments

@junlincc
Copy link
Collaborator

^
apache/superset#11418

@junlincc
Copy link
Collaborator Author

junlincc commented Jan 2, 2021

Need design input, top priority early Q1
Designer: @mihir174
Engineer: @zhaoyongjie

@geido
Copy link
Member

geido commented Jan 4, 2021

Nice community contribution over there. I'd love to take over this.

@zhaoyongjie
Copy link

nice meeting you Diego, glad to collaborate with you on the Superset.

@junlincc
Copy link
Collaborator Author

Proposed design(by @mihir174) - Dashboard native filter modals with time column select
After selecting time column and time grain in the modal, a pill will appear on the the left filter bar, click to open the same ad hoc timepicker in Explore.

Filters_Columns

Filters_Time

@zhaoyongjie @graceguo-supercat @mistercrunch @villebro @ktmud
we are not sure about if we can deprecate Show SQL Granularity Dropdown, Show SQL Time Column, Show Druid Granularity Dropdown and Show Druid Time Origin these four check boxes, risks, cost, alternative solutions etc. please let us know. Thanks!
Screen Shot 2021-01-26 at 8 26 37 PM

@villebro
Copy link

Both Druid options should be deprecated, but "SQL Granularity Dropdown" and "SQL Time Column" should be separate native filters, much like the Select, Range and Time Picker filters are (they only differ in the options and what types of values they emit).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants